Refactor the app for individual users and admin view for management #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update is incomplete. It's a work in progress.
the app is not collaborative anymore BREAKING CHANGE
swouf
added
feature
when managing the state of the elements, a reference to the state was given to Excalidraw that directly wrote in it. Therefor, the state was actually directly updated which was not the desired behaviour.
change AWS region and use env vars and secrets
minor upgrades in settings
spaenleh
approved these changes
Nov 17, 2023
src/utils/download.ts
Outdated
Comment on lines
113
to
117
| // action={ | ||
| // <IconButton aria-label="settings"> | ||
| // <MoreVertIcon /> | ||
| // </IconButton> | ||
| // } |
src/modules/common/TabPanel.tsx
Outdated
| aria-labelledby={`tab-${index}`} | ||
| {...other} | ||
| > | ||
| {/* TODO: Fix height problem with tabs. */} |
There was a problem hiding this comment.
Not sure. I don't remember fixing it but I cannot reproduce it now. It may depend on the screen resolution.
Co-authored-by: Basile Spaenlehauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I removed the collaborative feature (for now) and make the app individual. In the builder, I implemented an admin view for managing (preview and download for now) the drawings of all the members.
Working feature and improvements
Work in progress
Load initial drawing(see Upload template for new drawings #37)Actions(see Actions logging #38)Export actions, app data and settingsWhat is still not working (and won't be fixed in this PR)