feat: setup vite #79
Merged
feat: setup vite #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinaYahya
temporarily deployed
to
development
GitHub Actions
Inactive
spaenleh
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Looks good awesome !
Just a few dependencies you can remove and some tweeks to the config.
Do you have the graasp.svg favicon in /public ?
Can you try to deploy the app on dev (using the workflow dispatch with your branch) to check that base is configured correctly for when the site will be hosed on a path that is not the website root ?
LinaYahya
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close Using Vite as a development server #77