Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react-hook-form on register #474

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Nov 21, 2024

In this PR:

  • I add react-hook form to the register form
  • fix some small issues with url passed from the landing page

Copy link

gitguardian bot commented Nov 21, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14268592 Triggered Generic Password d72fee2 public/locales/de/auth.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@spaenleh spaenleh force-pushed the react-hook-form-register branch from 1bd7658 to d72fee2 Compare November 21, 2024 13:20
@spaenleh spaenleh force-pushed the react-hook-form-register branch from 7e61ae4 to fedbef6 Compare November 21, 2024 13:32
@spaenleh spaenleh self-assigned this Nov 21, 2024
@spaenleh spaenleh added the feature New feature or request label Nov 21, 2024
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It looks very good with react hooks form! 🚋

public/locales/en/common.json Show resolved Hide resolved
src/routes/auth/register.tsx Show resolved Hide resolved
src/modules/auth/components/register/Register.tsx Outdated Show resolved Hide resolved
src/modules/auth/components/register/Register.tsx Outdated Show resolved Hide resolved
src/modules/auth/components/register/Register.tsx Outdated Show resolved Hide resolved
src/modules/auth/components/register/Register.tsx Outdated Show resolved Hide resolved
src/modules/auth/components/register/Register.tsx Outdated Show resolved Hide resolved
src/routes/auth/register.tsx Outdated Show resolved Hide resolved
src/routes/auth/register.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 9c54420 Nov 22, 2024
4 checks passed
@spaenleh spaenleh deleted the react-hook-form-register branch November 25, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants