Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export member data notification is not handled by the messages translations #403

Open
spaenleh opened this issue Oct 30, 2024 · 0 comments
Open

Export member data notification is not handled by the messages translations #403

spaenleh opened this issue Oct 30, 2024 · 0 comments
Labels
chore Generic task or chore I:Account Interface Account

Comments

@spaenleh
Copy link
Member

spaenleh commented Oct 30, 2024 •
edited
Loading

The way the success and failure messages for the export member data notification are handled is not in line with the rest of the messages.

We should:

  • move the translated text to the messages namespace in transaltions.
  • remove the translated texts from this repo.
  • cleanup the notifier to reflect this change and only use translations from the messages namespace.

The original changes were introduced in #320
@spaenleh spaenleh added the chore Generic task or chore label Oct 30, 2024
spaenleh pushed a commit that referenced this issue Nov 26, 2024
@pyphilia
feat: redirects to account for profile (#403)
06887c7
spaenleh pushed a commit that referenced this issue Dec 16, 2024
@renovate
chore(deps): update yarn to v4.3.1 (#403)
fc5c5f8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@spaenleh spaenleh added the I:Account Interface Account label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Generic task or chore I:Account Interface Account
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spaenleh