-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump zlib to 1.3.1 #113
Bump zlib to 1.3.1 #113
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
Thank you for signing the OCA. |
Hi @Friendseeker, Thanks for the PR! IIRC, we picked this one commit of zlib because that fixed a bug that would cause problems with native images. Is there a particular reason you suggest to upgrade zlib? We should probably also upgrade musl and use what we recommend on our website: What do you think? |
That sounds fantastic. I shall update the PR to bump musl & zlib to the recommended version. |
It's unfortunately not that straightforward, but the build instructions are still relatively simple to follow. |
This PR bump zlib (used for
native-image-musl
) to 1.3.1, which is the latest zlib releasehttps://github.com/madler/zlib/releases/tag/v1.3.1