Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump zlib to 1.3.1 #113

Closed
wants to merge 1 commit into from
Closed

Conversation

Friendseeker
Copy link

This PR bump zlib (used for native-image-musl) to 1.3.1, which is the latest zlib release

https://github.com/madler/zlib/releases/tag/v1.3.1

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 24, 2024
@Friendseeker
Copy link
Author

Friendseeker commented Oct 24, 2024

Signed the OCA, pending OCA approval.

image

Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 25, 2024
@fniephaus
Copy link
Member

Hi @Friendseeker,

Thanks for the PR! IIRC, we picked this one commit of zlib because that fixed a bug that would cause problems with native images. Is there a particular reason you suggest to upgrade zlib? We should probably also upgrade musl and use what we recommend on our website: musl-1.2.4 and zlib-1.2.13.

What do you think?

@fniephaus fniephaus self-assigned this Oct 25, 2024
@Friendseeker
Copy link
Author

Hi @Friendseeker,

Thanks for the PR! IIRC, we picked this one commit of zlib because that fixed a bug that would cause problems with native images. Is there a particular reason you suggest to upgrade zlib? We should probably also upgrade musl and use what we recommend on our website: musl-1.2.4 and zlib-1.2.13.

What do you think?

That sounds fantastic. I shall update the PR to bump musl & zlib to the recommended version.

fniephaus added a commit that referenced this pull request Oct 28, 2024
@fniephaus
Copy link
Member

fniephaus commented Oct 28, 2024

bump musl

It's unfortunately not that straightforward, but the build instructions are still relatively simple to follow.
I've pushed af9cc8d to dev.

fniephaus added a commit that referenced this pull request Oct 28, 2024
fniephaus added a commit that referenced this pull request Oct 28, 2024
fniephaus added a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants