1.1.8 not updating the Windows environment variables

[ArloL]

I am using the action like this on windows-latest:

- uses: graalvm/[email protected]
  with:
    version: 22.2.0
    java-version: 17
    components: 'native-image'
    github-token: ${{ secrets.GITHUB_TOKEN }}
    cache: 'maven'

and now with 1.1.8 my windows setup stopped working.

My guess is that something is tripping up the required update to the environment variables which is still required with these older version graal versions I am sadly still stuck on.

The 1.1.7 log contains

Updating Windows environment...

while 1.1.8 does not.

Please let me know if I can provide more info.

PS Thanks for all the hard work maintaining open source software 🙏🏼

[fniephaus]

Thanks for the report, @ArloL!

and now with 1.1.8 my windows setup stopped working.

Could you provide us with a link to a failing build so that we can take a closer look?

[fniephaus]

Forgot to mention that there are some significant Windows enhancement since 22.2.0, so I recommend you upgrade to GraalVM for JDK like this:

- uses: graalvm/[email protected]
  with:
    distribution: 'graalvm' # for Oracle GraalVM, 'graalvm-community' for CE
    java-version: '17'
    github-token: ${{ secrets.GITHUB_TOKEN }}
    cache: 'maven'

[fniephaus]

It seems this could be related to 0fee1ab. I will try and come up with a fix tomorrow.

[fniephaus]

I just pushed a fix for this to dev, you can try it out via uses: graalvm/setup-graalvm@dev.

[ArloL]

Thanks for the quick reply ☺️

This is the build in question:
https://github.com/ArloL/chorito/actions/runs/8016511422/job/21923586863?pr=320

I would love to use the latest graalvm and java 21 but I am sadly hitting this issue oracle/graal#6793

Sadly @dev also does not update the windows environment: https://github.com/ArloL/chorito/actions/runs/8244996369/job/22548159025

[fniephaus]

I think I found the issue: javaVersion === javaVersion is always true:

setup-graalvm/src/msvc.ts

Line 35 in 5393c3d

if (javaVersion === javaVersion || graalVMVersion === VERSION_DEV) {

Will fix...

[fniephaus]

Ok, I think I got it. Could you please restart your build that runs against @dev?

[bhavikp19]

@fniephaus I can confirm that my windows build was also failing but now it is working if I use @dev. Thank you so much for looking into this and providing the fix.

[ArloL]

Thanks, @fniephaus and @bhavikp19. I too can confirm that it works: https://github.com/ArloL/chorito/actions/runs/8244996369/job/22571412312

[fniephaus]

The fix is merged and available via v1.1.8.2 and v1.

[ArloL]

Thanks, @fniephaus. I am not sure but I think dependabot will not update to 1.1.8.2. I tried recreating the PR:
ArloL/chorito#320 (comment) but the build still just used 1.1.8. I will wait and see if dependabot will open a new PR.

[fniephaus]

Why will dependabot not update to that version? Do we need to bump the patch version?

[fniephaus]

I just bumped the version to v1.1.9. Let me know if dependabot picks it up :)

[ArloL]

Thanks. Now dependabot closed the 1.1.8 issue and opened another PR for 1.1.9: ArloL/chorito#333

I am not sure why exactly that is necessary to be honest. My guess is that they only check for x.y.z version schemes and not x.y.z.a

[fniephaus]

Thanks for confirming! We'll keep this in mind and always push patch updates.