Adjust native-build tools to reachability-metadata.json #614
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
...ionalTest/groovy/org/graalvm/buildtools/gradle/JavaApplicationWithAgentFunctionalTest.groovy
Outdated
Show resolved
Hide resolved
...dle-plugin/src/main/java/org/graalvm/buildtools/gradle/internal/DefaultGraalVmExtension.java
Outdated
Show resolved
Hide resolved
...-plugin/src/main/java/org/graalvm/buildtools/gradle/tasks/actions/MergeAgentFilesAction.java
Outdated
Show resolved
Hide resolved
...-plugin/src/main/java/org/graalvm/buildtools/gradle/tasks/actions/MergeAgentFilesAction.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Cédric Champeau <[email protected]>
Co-authored-by: Cédric Champeau <[email protected]>
Co-authored-by: Cédric Champeau <[email protected]>
There was a problem hiding this comment.
Note to self: the section which creates a temporary file for the access filter file is good enough for now, but it should probably be implemented differently.
Basically, instead of having the agent configuration create the file and mutate itself, there should be a task which does this, and that task should be an implicit dependency of the agent configuration. It requires changes to both the Gradle and Maven plugins.
However, currently the agent options are "serialized" as strings, including paths, which prevents Gradle from understanding that the Collection<String> actually refer to file contents. This means that the up-to-date checking is incorrect, since it will only consider the file paths and not their contents. That is already the situation today, so nothing to change in this PR, it's just notes so that I remember later.
No description provided.