-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build nightly with the JDK 23 release branch (24.1) #750
Conversation
Mandrel build fails because we need a backport of oracle#9078 to be able to build with JDK 23+26 and better. PR for that in progress. Edit: PR with the backport to 24.1 is here: #751 |
@zakkak Not sure if this is the right approach. Maybe we should keep nightly on graal/master and change to JDK 24? And then possibly adding JDK 23 based builds test to the weekly schedule. Thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak Not sure if this is the right approach. Maybe we should keep nightly on graal/master and change to JDK 24? And then possibly adding JDK 23 based builds test to the weekly schedule. Thoughts?
Yes, that's the way we usually do it as we don't expect many changes on the release branch.
So we need to:
- move the 23-based builds to the weekly pipeline
- Create new issues for CI reporting (using @mandrel-bot) and use them in the corresponding jobs
- update the jdk version in the nightly pipeline
OK.
Any guidance as to how to do that? |
Withdrawing this PR as we'll fix this with a different approach. |
I open a new private window in firefox and login using the mandrel-bot credentials. You should have access to these through our shared vault (if not let me know in private). |
Partial fix for #749. This switches nightly builds to use the new
mandrel/24.1
branch (currently broken). CI builds for 24.2 (JDK 24) to follow once adoptium/api.adoptium.net#1077 is resolved.