-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial test of updated workflow with local graalvm artefacts #565
Initial test of updated workflow with local graalvm artefacts #565
Conversation
Keeping in draft until CI runs complete. |
One caveat of this update is that now mandrel and quarkus build are being serialized, since the quarkus build depends on the locally deployed maven artefacts from the earlier mandrel build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only have a couple of comments/questions.
1447875
to
a4c1a4e
Compare
The move to
See https://github.com/jerboaa/graal/actions/runs/6146546436/job/16682581790#step:12:415 But that's another issue. Moving out of draft. As CI testing seems to be doing what it's supposed to. |
This reminds me of quarkusio/quarkus#28650, we probably just need to expand the exclusion list. |
+1. Do you mind creating a patch for this, please? |
Sure, I 'll take care of it tomorrow |
https://github.com/jerboaa/graal/actions/runs/6146546436/job/16682586135 is the test run with this. The remaining issues are to do with this issue mentioned above and other known Mandrel IT issues tracked elsewhere. I'm going to merge. |
Unfortunately, that broke the GraalVM Community CI build. Fix in #566 |
@jerboaa it also breaks the "gradle tooling" test, see https://github.com/jerboaa/graal/actions/runs/6146546436/job/16682586395#step:12:465 It looks like we need a way to make gradle aware of the local artifacts. |
Thanks, yes I noticed it. I have no idea how to do that. Perhaps it needs to get some property set ( |
Anyone with more gradle experience than myself can probably fix this easily? I'll look into it later this week. |
I am also not familiar with gradle, but I will take care of it (reaching out to others if necessary). Thanks for your work on this. |
This is an initial set for CI testing the issue of JDK bytecode level
compatibility of graalvm maven artefacts. It uses the new
--maven-deploy-local
flag and does the following:
org/graalvm
artefacts as well as records the maven version being used by the local maven install.graal-sdk
version via a property, to the locally available one.org.graalvm
artefacts have been downloaded from the Internet when building quarkus.Test actions:
Closes: #526