Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Synchronization with upstream 23.0 branch for July CPU release #541

Merged
merged 91 commits into from
Jul 21, 2023

Conversation

zakkak
Copy link
Collaborator

@zakkak zakkak commented Jul 21, 2023

No description provided.

pejovica and others added 30 commits May 17, 2023 18:06
(cherry picked from commit eb7b761)
(cherry picked from commit 6e841cd)
(cherry picked from commit b7b8d2b)
(cherry picked from commit aa7eeda)
(cherry picked from commit da4f324)
(cherry picked from commit 188268f)
(cherry picked from commit 702ed41)
(cherry picked from commit 3c79ab0)
…on the GraalVM website.

PullRequest: graal/14797
PullRequest: graal/14830
…ecific files which are compiled with JDK 20.
marwan-hallaoui and others added 15 commits July 11, 2023 09:32
(cherry picked from commit 502bf25)
(cherry picked from commit 51032a2)
(cherry picked from commit 8b7e68f)
(cherry picked from commit 1fdd499)
…VM CE Container Images guide. Added Native Image getting started steps to GraalVM Windows installation guide./ Update required GraalVM support version in Native Image JFR doc.

PullRequest: graal/14969
@zakkak zakkak added this to the 23.0.1.1-Final milestone Jul 21, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 21, 2023
@zakkak zakkak requested review from jerboaa and Karm July 21, 2023 08:47
@zakkak
Copy link
Collaborator Author

zakkak commented Jul 21, 2023

The mandrel integration tests are Karm/mandrel-integration-tests#160

The interesting part though is that in the 23.0 branch the single compile unit patch is not present, so we can't backport just oracle#6937. We will probably need a number of backports to get this fixes in 23.0.

@jerboaa
Copy link
Collaborator

jerboaa commented Jul 21, 2023

The interesting part though is that in the 23.0 branch the single compile unit patch is not present, so we can't backport just oracle#6937. We will probably need a number of backports to get this fixes in 23.0.

Right. Yes, this will need to be considered. Lets wait and see how the fix develops in head first, though.

@zakkak zakkak merged commit 35d6811 into graalvm:mandrel/23.0 Jul 21, 2023
@zakkak zakkak deleted the 2023-07-21-23.0-CPU-sync branch July 21, 2023 12:35
@adinn
Copy link
Collaborator

adinn commented Jul 21, 2023

The interesting part though is that in the 23.0 branch the oracle#6419 is not present, so we can't backport just oracle#6937. We will probably need a number of backports to get this fixes in 23.0.

Ah, so if the single compile unit patch (oracle#6419) is not present in 23.0 then why do we want to backport oracle#6937? As far as I am aware, the debug info generated prior to oracle#6419 was not suffering from startup delays. Are there features provided by oracle#6419 or dependent follow-ups that we need?

@jerboaa
Copy link
Collaborator

jerboaa commented Jul 21, 2023

The interesting part though is that in the 23.0 branch the oracle#6419 is not present, so we can't backport just oracle#6937. We will probably need a number of backports to get this fixes in 23.0.

Ah, so if the single compile unit patch (oracle#6419) is not present in 23.0 then why do we want to backport oracle#6937?

We are seeing Karm/mandrel-integration-tests#160 test failures in CI. See below.

As far as I am aware, the debug info generated prior to oracle#6419 was not suffering from startup delays. Are there features provided by oracle#6419 or dependent follow-ups that we need?

See https://github.com/graalvm/mandrel/actions/runs/5620427175/job/15230467880#step:11:18570 it suggests Karm/mandrel-integration-tests#160 being present in 23.0. I don't know why.

@zakkak
Copy link
Collaborator Author

zakkak commented Jul 21, 2023

Hmm, I was wrong the single unit PR is in 23.0 oracle@53072937bd22. False alarm!

@adinn
Copy link
Collaborator

adinn commented Jul 21, 2023

Hmm, I was wrong the single unit PR is in 23.0 oracle@53072937bd22

Ok, that was what I thought.

So, the difficulty with backporting oracle#6937 (revert to CU per class) appears to be that 23.0 does not contain oracle#6625 (debug info for foreign types). That is why it doesn't backport cleanly.

I don't know if backporting both PRs in sequence will apply but I think it is likely(or, at least, will only require minor tweaks). If so then do we want to backport both? Or do we instead backport a modified variant of the CU per class PR?

@zakkak
Copy link
Collaborator Author

zakkak commented Jul 21, 2023

I would say both. I will try to see how hard it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.