Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the title and body when PR exists #353

Closed
wants to merge 6 commits into from

Conversation

gkuga
Copy link

@gkuga gkuga commented Dec 2, 2021

This PR addresses #309 and has breaking change.

Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update .github/workflows/test.yml to test the new functionality?

action.yml Outdated Show resolved Hide resolved
@gkuga gkuga force-pushed the feature/update-pr branch from 4e49f59 to e4fcedb Compare December 20, 2021 06:00
@gkuga
Copy link
Author

gkuga commented Dec 20, 2021

@gr2m Could you check the test for me? I think the following part will be !(steps.run.outputs.pull-request-number > 0).

- if: ${{ steps.run.outputs.result != 'updated' || steps.run.outputs.pull-request-number > 0 }}

- if: ${{ steps.run.outputs.pull-request-number > 0 }}

@gr2m gr2m self-assigned this Dec 21, 2021
@gr2m
Copy link
Owner

gr2m commented Dec 21, 2021

@gr2m Could you check the test for me? I think the following part will be !(steps.run.outputs.pull-request-number > 0).

Agreed! But something odd is going on here. When I change it to !(steps.run.outputs.pull-request-number > 0) it is still evaluated as steps.run.outputs.pull-request-number > 0, without the negation:

https://github.com/gr2m/create-or-update-pull-request-action/runs/4599942375?check_suite_focus=true#step:9:2

I'll investigate some more and file a ticket with GitHub

@gr2m
Copy link
Owner

gr2m commented Dec 21, 2021

okay never mind, I realized that while I worked on a pull request, the actions that were executed were still form the default branch. I think the problem is with thepull_request_target trigger. Now with the approve runs flow I can change it back to pull_request which should checkout the correct branch, I hope

@gr2m gr2m force-pushed the feature/update-pr branch from a79ba5c to dbcf3b5 Compare December 21, 2021 21:27
@gr2m gr2m closed this in #416 Dec 21, 2021
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants