Fix warnings & deprecation messages in GitHub actions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
2 times, most recently
from
2fa0107 to
5ac6aa2
Compare
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
5ac6aa2 to
d2d7a66
Compare
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
d2d7a66 to
ba8b134
Compare
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
ba8b134 to
e0a51e6
Compare
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
e0a51e6 to
b48f43d
Compare
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
b48f43d to
6b6f948
Compare
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
6b6f948 to
3b7c77b
Compare
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
changed the title
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
3b7c77b to
9bfb211
Compare
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
ljubon
had a problem deploying
to
armada-dockerhub
GitHub Actions
Failure
|
I have one general comment. As in other PRs, let's focus only on what the scope of the PR is, so in this case, no need for formatting changes, just updating the versions. Also, please provide working examples, with updated actions versions. |
Thanks Ivan 🙏 |
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
3 times, most recently
from
88ce995 to
5e9fe9c
Compare
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
4 times, most recently
from
7df5b71 to
bec1cb5
Compare
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
bec1cb5 to
9cabd29
Compare
Signed-off-by: Ljubo Nikolic <[email protected]> Signed-off-by: Ljubo Nikolić <[email protected]>
Signed-off-by: Ljubo Nikolic <[email protected]> Signed-off-by: Ljubo Nikolić <[email protected]>
Signed-off-by: Ljubo Nikolic <[email protected]> Signed-off-by: Ljubo Nikolić <[email protected]>
Signed-off-by: Ljubo Nikolic <[email protected]> Signed-off-by: Ljubo Nikolić <[email protected]>
Signed-off-by: Ljubo Nikolic <[email protected]> Signed-off-by: Ljubo Nikolić <[email protected]>
…flow Signed-off-by: Ljubo Nikolić <[email protected]>
ljubon
force-pushed
the
oss-586-resolve-deprecation-and-warnings
branch
from
9cabd29 to
b350430
Compare
ljubon
force-pushed
the
master
branch
2 times, most recently
from
9fabcd0 to
e4e896e
Compare
|
closing internal PR as it's merged upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
CI: Resolve deprecation & warning messages in workflows
What this PR does / why we need it:
Node16 has been out of support since September 2023. - more info in the post
Optional
Slack CI Alertsworkflow and currently doesn't address this issueWhich issue(s) this PR fixes:
https://github.com/G-Research/gr-oss/issues/586
Testing results
As the desired state is a job without warnings/deprecation messages, in this commit I removed some of the conditions in Armada workflow in order to test all workflows and their actions
FAILED (need action update) 🟠
Slack CI Alerts
Slack CI Alertsworkflow Mo-Fatah/ci-alerts@v2 within the latest version doesn't address Node 16 deprecations warningsPASSED 🟢
CI / Build / Tests / Lint
Python Client
Python Airflow Operator
CodeQL
Release Armada components
(workflow failed due to missing tag, but no deprecated/warnings are shown)
Release Armada components - RC
(workflow failed due to missing tag, but no deprecated/warnings are shown)
Check required jobs
(workflow failed due to missing ref, but no github/scripts@v7 showed there is no warnings/deprecatations)