Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User settabel SSB Stepsize #928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ulrichloose
Copy link
Contributor

for #920

@pe1chl
Copy link

pe1chl commented Jan 25, 2021

When you go for user-settable it may be even better to do it for every group of modes:
AM
Narrow FM
WFM
CW

@ulrichloose
Copy link
Contributor Author

A bit of work for little result (;-)

Honestly? I only made this change to the SSB Stepsize as a "finger exercise" and to be able to use Github better. If it had been up to me, one would have simply changed the 100 Hz to 50 Hz ...

As it looks, neither one - 50 Hz fix - nor the other - adjustable - nor the third - for all demodulators - will find its way into gqrx.

@pe1chl
Copy link

pe1chl commented Jan 26, 2021

Well I agree that a user-settable stepsize would be a bit of overkill for the issue I raised, I just edit the source after git pull for the step to be 50Hz instead of 100Hz and it works fine for me. I submitted the change in issue #920 but apparently there is more to be done, as it was registered as a "feature request" rather than simply being implemented. Maybe it requires more discussion or agreement between some people?
I thought a user-settable variant (with defaults set to the steps we have now) would have more chance of getting implemented, but I do not have the knowledge of the program to be able to implement that like you did. But, it seems to me that once that hurdle has been overcome, it would be easy to copy/paste the same code for 5 different mode groups (I could likely do that starting from your patch).
Good idea to do some exercise with GitHub. Way in the past I have been able to make a pull request for another program and submit it so the author could include it, but then later GitHub made some change and I was unable to repeat it from then. Apparently some authorization issue I don't understand. So I can only do git pull now :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants