Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set UDP packet size limit to 512 bytes #367

Merged
merged 1 commit into from
Apr 22, 2016
Merged

Conversation

a1k0n
Copy link

@a1k0n a1k0n commented Apr 21, 2016

Workaround for #363. Substantially more reliable on OS X with this, though the reason packets are lost remains elusive.

Not honestly sure whether this should be user-configurable, or to change the default in GNU radio, or what. What do you think @csete ?

@csete
Copy link
Collaborator

csete commented Apr 22, 2016

Thanks for the patch.

I'd like to avoid user configurable parameters as much as possible. If we wrap this change into

#ifdef GQRX_OS_MACX
    d_sink = gr::blocks::udp_sink::make(sizeof(short), "localhost", 7355, 512);
#else
    d_sink = gr::blocks::udp_sink::make(sizeof(short), "localhost", 7355);
#endif

then we don't break anything for existing users. We can in time test and see if it works just as well on linux and use the same packet size. If you resubmit with the ifdef or something similar I will merge it.

Workaround for gqrx-sdr#363. Substantially more reliable on OS X with this,
though the reason packets are lost remains elusive.
@a1k0n
Copy link
Author

a1k0n commented Apr 22, 2016

Ok, #ifdef'd. Please take another look.

@csete
Copy link
Collaborator

csete commented Apr 22, 2016

Excellent, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants