Github Actions : Add Windows CI #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argilo
reviewed
Nov 28, 2023
.github/workflows/ci.yml
Outdated
| - name: Clone and Build GNU Radio | ||
| shell: msys2 {0} | ||
| run: | | ||
| git clone --recursive https://github.com/cozycactus/gnuradio.git |
There was a problem hiding this comment.
I think I'll hold off merging this PR until gnuradio/gnuradio#6971 is merged. That will let us use the upstream GNU Radio.
There was a problem hiding this comment.
We should be able to switch this to upstream now.
I think --recursive can be removed as well, since GNU Radio doesn't have submodules anymore.
argilo
reviewed
Nov 28, 2023
argilo
reviewed
Nov 28, 2023
.github/workflows/ci.yml
Outdated
| cd gnuradio | ||
| git checkout fixmingw64 | ||
| mkdir build && cd build | ||
| cmake -DCMAKE_INSTALL_PREFIX=C:/gqrx -G Ninja .. |
There was a problem hiding this comment.
We could perhaps speed this up by only building the components that Gqrx needs:
-DENABLE_DEFAULT=False \
-DENABLE_GNURADIO_RUNTIME=True \
-DENABLE_GR_ANALOG=True \
-DENABLE_GR_AUDIO=True \
-DENABLE_GR_BLOCKS=True \
-DENABLE_GR_DIGITAL=True \
-DENABLE_GR_FFT=True \
-DENABLE_GR_FILTER=True \
-DENABLE_GR_NETWORK=True \
This lines up with the other platforms.
|
Thanks for this. I made a few improvements and will merge once CI is happy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.