Add feature to update existing bookmark #1306
Conversation
| @@ -84,6 +84,15 @@ struct BookmarkInfo | |||
| { | |||
| return frequency < other.frequency; | |||
| } | |||
|
|
|||
| bool operator==(const BookmarkInfo &other) const | |||
There was a problem hiding this comment.
Where is this used? In stable_sort or indexOff?
There was a problem hiding this comment.
As you edited. 😄 This is needed for indexOf.
|
I don't understand why this is needed. It is already possible to update a bookmark by clicking on the frequency, name, modulation, or bandwidth. |
Actually it's possible to edit existing bookmarks, i.e. hand type new values in the fields. |
|
I have checked that contextual |
Ah, OK. What do you typically use this feature for? |
When exploring a frequency range with sparse emissions. I can display the range at full scale and place coarse bookmarks where the waterfall is showing emissions. Then I can individually zoom in the frequency band and fine-tune each bookmark to more precise freq and bandwidth (and eventually fix the modulation if it was incorrectly set). |
|
Thanks for the explanation. It does sound useful to be able to update a bookmark that way. |
|
I have implemented something similar to this functionality in my fork: trying to create a bookmark on top of existing bookmark updates demodulator, filter bandwidth and other settings (most of demodulator/audio processing settings can be stored to a bookmark) instead of creating a new one. |
This PR mainly adds a feature that an existing can be updated using contextual menu:
When updating, frequency + bandwidth + modulation are updated.
Bookmarks are re-sorted and selected bookmark is kept selected at its new location.
Also this PR changes that "Delete bookmark" (and "Update bookmark" as well) is only shown if contextual menu is called when hovering a bookmark. It's not more displayed when right-clicking on an empty area of the QTableView. Only "Add new bookmark" is available in this case.