Install the icon, desktop entry, and appstream metadata in cmake #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gqrx doesn't currently install its icon, desktop entry file, or appstream metadata file. Debian takes care of installing the icon and desktop entry file (but not the appstream metadata file) in its
debian/gqrx-sdr.installfile. I think it would be best for Gqrx to install all these files in its own build process, so that they'll also be installed when users build Gqrx from source. This is similar to what GNU Radio does: https://github.com/gnuradio/gnuradio/blob/b42996b1569722d34dad2057406e4a6c3de99366/grc/scripts/freedesktop/CMakeLists.txt#L24-L40