Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick fix for #1019 #1020

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Quick fix for #1019 #1020

merged 2 commits into from
Dec 16, 2021

Conversation

vladisslav2011
Copy link
Contributor

@vladisslav2011 vladisslav2011 commented Dec 15, 2021 •
edited by argilo
Loading

Fixes #1019.

Store previous DSP state in a variable to use it later as on_actionDSP_triggered changes ui->actionDSP state.

@vladisslav2011 vladisslav2011 mentioned this pull request Dec 15, 2021
Merged
@argilo
Copy link
Member

argilo commented Dec 16, 2021 •
edited
Loading

It looks like MainWindow::stopIqPlayback has the same bug. Perhaps we should fix that here too.

@argilo
Copy link
Member

argilo commented Dec 16, 2021

Actually, it looks like applying the same fix to MainWindow::stopIqPlayback would cause the DSP to always start when I/Q playback is stopped, which we don't want. Best to leave any fix to a separate pull request, I guess.

@vladisslav2011 @argilo
Quick fix for gqrx-sdr#1019
c70103f 
Store previous DSP state in a variable to use it later as
on_actionDSP_triggered changes ui->actionDSP state.
argilo
argilo approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@argilo argilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll merge this once CI passes.

@argilo argilo merged commit 62aa31e into gqrx-sdr:master Dec 16, 2021
@vladisslav2011 vladisslav2011 deleted the dsp_stop_fix branch December 16, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argilo argilo argilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Changing IO devices stops the DSP
2 participants
@vladisslav2011 @argilo