-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More robust partial data handling #104
Conversation
Sorry this does more than #102 specified – I realized there's an issue with write/read round-trips always resulting in valid data, because |
hmm... |
Is there a reason why |
@smkhalsa right you are – did that before implementing the Went ahead and refactored, added |
@smkhalsa could you take a look at this when you get the chance? I kind of ended up making zino-hofmann/graphql-flutter#754 fairly large, and it depends on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
path
toPartialDataException
to surface invalid pathsacceptPartialData=true
tonormalizeFragment
andnormalizeOperation
to allow for the rejection of structurally incomplete results (i.e.
{}
!= '{ foo: null }')denormalizeFragment
anddenormalizeOperation
now have ahandleException=true
flag which can be disabled to throw rather than return nullvalidateOperationDataStructure
closing [normalize feature req] validation and safety utils #102 (handleException=false
by default)returnPartialData
toconfig.allowPartialData
indenormalizeNode
as partial data is now a cross cutting concern