Upgrade Helm and other exekube bits #30
Conversation
Includes fixes to build and run `google-cloud-monitoring` and `-logging` gems, which depend on `grpc` and `protobuf` and their native extensions (see protocolbuffers/protobuf#4460, protocolbuffers/protobuf#2335, gliderlabs/docker-alpine#424, grpc/grpc#6525 for details)
This prevents lot of `.terragrung-cache` dirs in local environments and some issues after upgrading Terraform provider versions.
dockerfiles/alicloud/Dockerfile
Outdated
| ENV TERRAFORM_PROVIDER_HELM_VERSION 0.6.2 | ||
| ENV TERRAFORM_PROVIDER_ALICLOUD_VERSION 1.9.1 | ||
| # Terragrun tcache directory |
dockerfiles/aws/Dockerfile
Outdated
| ENV TERRAFORM_PROVIDER_HELM_VERSION 0.6.2 | ||
| # Terragrun tcache directory |
dockerfiles/google/Dockerfile
Outdated
| ENV TERRAFORM_PROVIDER_HELM_VERSION 0.6.2 | ||
| ENV GOOGLE_CLOUD_MONITORING_VERSION 0.29.2 | ||
| ENV GOOGLE_CLOUD_LOGGING_VERSION 1.5.7 | ||
| # Terragrun tcache directory |
dockerfiles/google/Dockerfile
Outdated
| @@ -52,6 +54,9 @@ RUN apk --no-cache add \ | |||
| g++ \ | |||
| make \ | |||
| ruby-dev && \ | |||
| # Following is needed for various native exptension issues on Alpine with protobuf and grpc plugins | |||
dockerfiles/google/Dockerfile
Outdated
| @@ -52,6 +54,9 @@ RUN apk --no-cache add \ | |||
| g++ \ | |||
| make \ | |||
| ruby-dev && \ | |||
| # Following is needed for various native exptension issues on Alpine with protobuf and grpc plugins | |||
There was a problem hiding this comment.
This is a little vague, so I might link to the most relevant issue(s) here, or back to the description of this PR.
There was a problem hiding this comment.
Thanks. So there are like 4 different issues I've hit and each of them requires some part of the fix and if not present. will lead to a different issue(s):
- doing the system
gem update - explicitly installing
google-protobufwithrubyplatfotm - same for
grpcand it's dependencyetc - pinning down the protobuf version at
3.6.1
I think thiat is a bit too long to explain in the code. All of the issue(s) are referenced in the commit message (as well as in the PR description), so I'll remove the comment here (I agree it's not very useful).
|
Please fix typos and then LGTM. |
|
Thanks for reviews @mrtyler and @natarajaya - I've fixed the typos and removed the comment from the code (detailed commit message contains references to the relevant issues). |
This PR:
google-cloud-monitoringand-logginggems, which depend ongrpcandprotobufand their native extensions (see Segmentation Fault (Segfault) on the ruby gem protocolbuffers/protobuf#4460, Does not work on ruby:2.3-alpine docker image protocolbuffers/protobuf#2335, alpine-3.8 breaks grpc gem installation gliderlabs/docker-alpine#424,gem instal grpcfails to compile boringssl grpc/grpc#6525 for details).terragrung-cachedirs in local environments and some issues after upgrading Terraform provider versionsDepends on gpii-ops/gpii-infra#242