Make BadGlobalMuonTagger METFilter compliant. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed this PR due to corruption caused by a base fork change. Cloned to #13. |
gpetruc
pushed a commit
that referenced
this pull request
Aug 16, 2017
solved the problem with InputTag
gpetruc
pushed a commit
that referenced
this pull request
Dec 6, 2023
make startup allocations safe on platforms where dlsym allocates memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the pass/fail logic of the BadGlobalMuonTagger in order be compliant with existing MET filters.
Instead of returning a
founddecision that denoted the existance of a found bad/duplicate muon, the filter now returns thepassdecision. As a result, the module can be added to a sequence or path without sequence negation (~module/module.__invert__).The module also produces a bool for the
passdecision now, that can be evaluated in following analyzers when using the tagging mode with the same recipes as already described here.Edit: Ok, I just found a HN with an identical proposal -.- ... but at least you might add this with a single click ;)