Fix tests for Grails 7 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cglib has problems, bytebuddy works (and is the recommended choice from Spock).
Create a superclass that is not marked as a Gorm entity.
The tests that are dependent on working domain inheritance are marked as pending.
This test already had a duplicate for handling running on Java 17. Now that the project is baselined at Java 17 this also had to be conditioned. The test can probably be removed, but it is kept for documentation purposes.
codeconsole
approved these changes
Sep 15, 2024
| @@ -3,7 +3,13 @@ package grails.plugin.formfields.mock | |||
| import grails.persistence.Entity | |||
|
|
|||
| @Entity | |||
| class Person { | |||
| class Person extends HomoSapiens {} | |||
There was a problem hiding this comment.
@matrei nice, I actually had thought about that last night and was wondering why we didn't do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.