Merge pull request #346 from codeconsole/order-except

Support order and except attributes simultaneously
gpc · Sep 5, 2024 · 3a49947 · 3a49947
2 parents 970ee8b + 29ceb58
commit 3a49947
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/grails-app/taglib/grails/plugin/formfields/FormFieldsTagLib.groovy b/grails-app/taglib/grails/plugin/formfields/FormFieldsTagLib.groovy
@@ -564,10 +564,10 @@ class FormFieldsTagLib {
 		List<PersistentProperty> properties
 
 		if (attrs.order) {
+			def orderBy = getList(attrs.order)
 			if (attrs.except) {
-				throwTagError('The [except] and [order] attributes may not be used together.')
+				orderBy = orderBy - getList(attrs.except)
 			}
-			def orderBy = getList(attrs.order)
 			properties = orderBy.collect { propertyName ->
 				fieldsDomainPropertyFactory.build(domainClass.getPropertyByName(propertyName))
 			}

diff --git a/src/test/groovy/grails/plugin/formfields/taglib/AllTagSpec.groovy b/src/test/groovy/grails/plugin/formfields/taglib/AllTagSpec.groovy
@@ -86,18 +86,17 @@ class AllTagSpec extends AbstractFormFieldsTagLibSpec implements TagLibUnitTest<
 
     }
 
-    @Issue('https://github.com/grails3-plugins/fields/issues/9')
-    void 'order attribute and except attribute are mutually exclusive'() {
+    @Issue('https://github.com/gpc/fields/issues/347')
+    void 'allow order and except attributes'() {
         given:
         views["/_fields/default/_field.gsp"] = '|${property}|'
         views["/_fields/default/_wrapper.gsp"] = '${widget}'
 
         when:
-        applyTemplate('<f:all bean="personInstance" except="password" order="name, minor, gender"/>', [personInstance: personInstance])
+        def output = applyTemplate('<f:all bean="personInstance" except="minor, password" order="name, minor, gender"/>', [personInstance: personInstance])
 
         then:
-        GrailsTagException e = thrown()
-        e.message.contains 'The [except] and [order] attributes may not be used together.'
+        output == '|name||gender|'
     }
 
     void "f:all tag supports theme"() {