Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Danish future replaced regions #458

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix Danish future replaced regions #458

merged 1 commit into from
Nov 27, 2024

Conversation

Ainali
Copy link
Member

@Ainali Ainali commented Nov 27, 2024

Description

Existing regions were being excluded although not being replaced until 2027.
(Nice with proactive Danish Wikidata work though!)

Note that the check query test will fail as there are one too many ministries, so this need to be merge despite it.

PR Details

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Code refactor

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • Any query changes have been verified and are working correctly.
  • I have updated relevant documentation (if needed).
  • I have added unit tests or performed manual testing where necessary.

Were being excluded although not being replaced until 2027.
@Ainali Ainali requested a review from Abbe98 November 27, 2024 11:48
@Ainali Ainali merged commit 79a8fa1 into main Nov 27, 2024
3 checks passed
@Ainali Ainali deleted the fix-danish-replaced branch November 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants