Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ministries of Ghana and fix workflow #456

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Add ministries of Ghana and fix workflow #456

merged 6 commits into from
Nov 25, 2024

Conversation

Ainali
Copy link
Member

@Ainali Ainali commented Nov 25, 2024

Description

Add ministries of Ghana.

Thanks to having this change, I could also experiment with the the workflow that checks a change in a query until I got it correct. Now it runs and checks!

PR Details

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Code refactor

Checklist

Please ensure the following before submitting the PR:

  • I have tested the changes locally, and they work as expected.
  • The code follows the project's coding standards and conventions.
  • Any query changes have been verified and are working correctly.
  • I have updated relevant documentation (if needed).
  • I have added unit tests or performed manual testing where necessary.

@Ainali Ainali requested a review from RVA2869 November 25, 2024 17:27
@Ainali Ainali force-pushed the add-ghana-ministries branch from 31d9d79 to 2386915 Compare November 25, 2024 18:23
@Ainali Ainali requested a review from Abbe98 November 25, 2024 18:37
@Ainali Ainali changed the title Add ministries of Ghana Add ministries of Ghana and fix workflow Nov 25, 2024
@Abbe98
Copy link
Member

Abbe98 commented Nov 25, 2024

Do you want to merge the workflow commits before we merge this one?

@Ainali
Copy link
Member Author

Ainali commented Nov 25, 2024

Do you want to merge the workflow commits before we merge this one?

I am fine with this as is, since it tells me the story of why it looks like it does. If you rather want those squashed , I can do that.

Copy link
Member

@Abbe98 Abbe98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's okay as is.

@Ainali Ainali merged commit dc21461 into main Nov 25, 2024
3 checks passed
@Ainali Ainali deleted the add-ghana-ministries branch November 25, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants