Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elo rating #278

Closed
wants to merge 3 commits into from
Closed

Elo rating #278

wants to merge 3 commits into from

Conversation

SameerDalal
Copy link
Collaborator

Hi Everyone!

Spoke with Prof. Chen today and the next feature we would like to develop is the ELO rating feature for quantum. Here are some of my thoughts/questions:

1). Do we want each user to have a different ELO rating for each type of variant?
2). Players can agree to make (or not to make) a game elo-rated
3). One of the issues with the ELO ranking system is that a person can chose not to play games to maintain their high rank. To combat this, we should implement some type of activity bonus for playing at least one game per month and a consequence if they don't.
4). Players should be matched with others that have similar rank.

@benjaminpjones
Copy link
Collaborator

benjaminpjones commented Jun 20, 2024

1). Do we want each user to have a different ELO rating for each type of variant?

Yes, I think. Although it might be interesting to maintain an "overall" rank and see how it compares

2). Players can agree to make (or not to make) a game elo-rated

This is fine, but honestly I'd be okay with just rating all games too.

3). One of the issues with the ELO ranking system is that a person can chose not to play games to maintain their high rank. To combat this, we should implement some type of activity bonus for playing at least one game per month and a consequence if they don't.

The server not well populated yet - I don't want to "punish" people for not playing. I would be okay with increasing the deviation parameter over time though, since accuracy does go down over time. I believe the ELO/glicko systems allow for this.

Also are you/Zi strongly attached to Elo? I understand Glicko2 is generally considered an improvement on ELO (but still similar), and glicko2 does update RD to reflect inactivity.

4). Players should be matched with others that have similar rank.

Auto-match would be great! I imagine that's a feature on its own.


Meta-comment - we can probably have discussions like these in the issues (PRs are usually for code), but I appreciate you gathering feedback early in the process!

@SameerDalal
Copy link
Collaborator Author

The server not well populated yet - I don't want to "punish" people for not playing. I would be okay with increasing the deviation parameter over time though, since accuracy does go down over time. I believe the ELO/glicko systems allow for this.

Got it!

Also are you/Zi strongly attached to Elo? I understand Glicko2 is generally considered an improvement on ELO (but still similar), and glicko2 does update RD to reflect inactivity.

I have no preference for what type of rating system we want to use, but I will talk to Prof. Chen about it again and see if he has some preference.

Meta-comment - we can probably have discussions like these in the issues (PRs are usually for code), but I appreciate you gathering feedback early in the process!

Sorry about that, I assumed I would have some code later, so I opened up a PR to keep this discussion in one section. Next time, I'll be sure to open up an issue first!

@benjaminpjones benjaminpjones mentioned this pull request Jun 21, 2024
@benjaminpjones
Copy link
Collaborator

Closing this, we can continue discussion on #279. Feel free to open a new PR when you have some code!

(Also, I might recommend starting a new branch off current govariants/main - no need to start with a merge commit 😃)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants