Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed chosen_lib from tooling. #72

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Conversation

stooit
Copy link
Collaborator

@stooit stooit commented Oct 7, 2020

The chosen library should be shipped/bundled with the distribution rather than in tooling.

@stooit
Copy link
Collaborator Author

stooit commented Oct 7, 2020

Upstream PR: govCMS/GovCMS8#556

@stooit stooit merged commit b510e0f into develop Oct 8, 2020
@stooit stooit deleted the feature/remove-chosen-lib branch October 8, 2020 00:04
@simesy
Copy link
Contributor

simesy commented Oct 9, 2020

There is (or was) a circular dependency somewhere that this solved. Because chosen depends on chosen_lib. It might have been in the satis...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants