Add more tests to ensure proper handling of undefined #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this code over at
node-saml
, I found that we were sendingundefined
ornull
on occasion. I've added some tests, but changed no behavior, to validate what was actually happening internally. I then updated the TypeScript types to match the tests.This PR focuses on minimal changes for correctness involving these new tests, so I didn't address any of the broader feedback on types.