Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow action version updates #389

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

cyb3rko
Copy link
Contributor

@cyb3rko cyb3rko commented Nov 25, 2024

Bumping the actions to much newer versions

with:
distribution: 'zulu'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why zulu and not temurin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh okay, do you have a preference? I think temurin is more open, as it's maintained eclipse?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://whichjdk.com/, temurin sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly use Zulu or SapMachine, but only because they just work. I never bothered to change it for my projects.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then let's go with temurin, if the build succeeds (:.

@jmattheis jmattheis merged commit 69c0d04 into gotify:master Dec 1, 2024
2 checks passed
@cyb3rko cyb3rko deleted the workflow-updates branch December 1, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants