dotsv2: remove jitters entirely #368

howardjohn · 2023-09-08T20:24:18Z

As best I can tell, this fully fixes #352

While there were a variety of workarounds I tried to fix this, which had some improvement, the real root cause is doing clear screen; write. This leaves some time where each cell in the terminal goes from <something> -> empty -> <something>, which leads to blinking.

Instead, we can write and clear as we go. This has the same end result, but avoids the intermediate step where we have an empty cell.

This PR is probably not acceptable as-is as it doesn't even compile on windows. Not sure the best steps there, I neither have experience with implementing this in windows nor a machine to test on. We could keep the old implementation for windows, possibly.

dnephin · 2023-09-13T02:43:29Z

Nice! This works great for me. I also don't have a windows machine. I think leaving the old implementation for windows would be fine.

howardjohn · 2023-09-14T18:08:18Z

Nice! This works great for me. I also don't have a windows machine. I think leaving the old implementation for windows would be fine.

SGTM, I left it as-is for now and commented that it could be improved in the future if someone wants

dnephin

Thank you making these improvements!

dnephin · 2023-09-16T18:49:19Z

testjson/testdata/format/dots-v2.out

+[0K[?25h[?25l[5A[0K
+[0K


I think it's pretty cool that you can see the functional change to the logic by looking at the golden file. The control sequences moved to a different place in the output.

This had some previous fixes: * gotestyourself#368 * gotestyourself#354 These do not fully fix the problem, only mask the issues. The real issues arise when there are 100s of packages to display, but only so much screen space. As each one bounces around, the text is entirely unreadable. The previous approaches was to more effieciently update the lines to make it more incremental. The approach here is different - simple but extremely effective. Instead of trying to constantly write out the entire set of lines/packages under test, on each event, we keep track of a active and completed set of packages. Once a package is completed, we write it out one last time, and then never overwrite it. The active set is treated as we do today. This means if we have 8 core machine and 1000 packages, we are only updating 8 lines at a time, which removes all jitteriness.

howardjohn force-pushed the dotsv2/line-by-line branch from 26f5f9e to df90c90 Compare September 14, 2023 18:07

howardjohn force-pushed the dotsv2/line-by-line branch from df90c90 to 53ec696 Compare September 14, 2023 18:12

dotsv2: remove jitters

eb1c70d

howardjohn force-pushed the dotsv2/line-by-line branch from 53ec696 to eb1c70d Compare September 15, 2023 15:10

dnephin approved these changes Sep 16, 2023

View reviewed changes

dnephin merged commit ec99a25 into gotestyourself:main Sep 16, 2023

dnephin mentioned this pull request Sep 16, 2023

WIP: dotsv2: improvements to reduce text jitteriness #353

Closed

howardjohn mentioned this pull request Mar 5, 2024

dots-v2: fix jitteriness, again #388

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dotsv2: remove jitters entirely #368

dotsv2: remove jitters entirely #368

howardjohn commented Sep 8, 2023

dnephin commented Sep 13, 2023

howardjohn commented Sep 14, 2023

dnephin left a comment

dnephin Sep 16, 2023

		[0K[?25h[?25l[5A[0K
		[0K

dotsv2: remove jitters entirely #368

dotsv2: remove jitters entirely #368

Conversation

howardjohn commented Sep 8, 2023

dnephin commented Sep 13, 2023

howardjohn commented Sep 14, 2023

dnephin left a comment

Choose a reason for hiding this comment

dnephin Sep 16, 2023

Choose a reason for hiding this comment