Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): separate int53 and int64 encoding #605

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Dec 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #605 (4b7d600) into main (cfbba9a) will decrease coverage by 0.47%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
- Coverage   68.92%   68.45%   -0.48%     
==========================================
  Files         394      395       +1     
  Lines       18487    18555      +68     
==========================================
- Hits        12742    12701      -41     
- Misses       4911     5018     +107     
- Partials      834      836       +2     
Impacted Files Coverage Δ
bin/decode.go 98.55% <0.00%> (-1.45%) ⬇️
bin/encode.go 95.55% <0.00%> (-4.45%) ⬇️
internal/gen/make_field.go 78.10% <25.00%> (-1.75%) ⬇️
tdjson/decoder.go 21.73% <42.85%> (+9.81%) ⬆️
tdjson/encoder.go 47.61% <60.00%> (+21.14%) ⬆️
telegram/updates/update.go 9.52% <0.00%> (-90.48%) ⬇️
telegram/message/typing.go 68.00% <0.00%> (-20.68%) ⬇️
telegram/updates/gap_buffer.go 71.42% <0.00%> (-10.72%) ⬇️
telegram/updates/state_channel.go 45.75% <0.00%> (-7.08%) ⬇️
telegram/updates/sequence_box.go 80.53% <0.00%> (-0.89%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbba9a...4b7d600. Read the comment docs.

@ernado ernado merged commit eb4dea3 into gotd:main Dec 6, 2021
@tdakkota tdakkota deleted the fix/tdlib-int64-encoding branch December 6, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants