Command empty strings #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea behind this commit is to set the stage for adding aditional logging metadata.
* Added new flags `--log-level` and `-l` to be consistent with other goss flags. * `--loglevel` and `-L` will be deprecated in a future release * Log level accepts any casing, so DEBUG and debug are both valid cli opts * Add log level support for `add` and `autoadd` commands
Changed the behavior of `goss add` on a command, if the value of stdout or stderr is empty, it will be defaulted to an empty string instead of an empty array. The behavior remains unchanged when there is output; the value will be an array. This approach provides the following benefits: * Tests will fail if an empty string receives a value. * Arrays allows for simpler deletion of lines that are not relevant to the test assertion. closes #820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Changed the behavior of
goss addon a command, if the value of stdout or stderr isempty, it will be defaulted to an empty string instead of an empty
array. The behavior remains unchanged when there is output; the value
will be an array.
This approach provides the following benefits:
to the test assertion.