Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edge case in truncate function allowing too long slugs #74

Merged
merged 7 commits into from
Sep 30, 2022
+38 −17
Merged

fix edge case in truncate function allowing too long slugs #74

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5ae7f86
fix edge case in truncate function allowing too long slugs
Aug 1, 2022
05a1da2
Update slug_test.go
matrixik Sep 27, 2022
9d02f61
Add testcase for edge casf
matrixik Sep 27, 2022
4c69b3d
Merge branch 'master' into fix-truncate-function
matrixik Sep 27, 2022
133079c
Improve TestSlugMakeSmartTruncate cases
matrixik Sep 27, 2022
fb70068
Even more smart truncate test cases
matrixik Sep 30, 2022
c05c02d
Fix bug in smast truncate
matrixik Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve TestSlugMakeSmartTruncate cases
@matrixik
matrixik authored Sep 27, 2022
commit 133079cd8453025964740da2e8a71ca316195f3f
24 changes: 21 additions & 3 deletions slug_test.go
View file
Original file line number Diff line number Diff line change
@@ -283,15 +283,33 @@ func TestSlugMakeSmartTruncate(t *testing.T) {
want string
smartTruncate bool
}{
{"DOBROSLAWZYBORT", 100, "dobroslawzybort", true},
{"Dobroslaw Zybort", 100, "dobroslaw-zybort", true},
{"Dobrosław Żybort", 5, "dobro", true},
{"Dobroslaw Zybort", 9, "dobroslaw", true},
{"Dobroslaw Zybort", 12, "dobroslaw", true},
{"Dobroslaw Zybort", 15, "dobroslaw", true},
{"Dobroslaw Zybort", 16, "dobroslaw-zybort", true},
{"Dobroslaw Zybort", 17, "dobroslaw-zybort", true},
{"Dobroslaw Zybort", 100, "dobroslaw-zybort", true},
{"abc", 2, "ab", true},
{"abc-", 2, "ab", true},
{"abc", 4, "abc", true},
{"abc-", 4, "abc", true},
{"abc-de", 4, "abc", true},
{"abc-de", 5, "abc", true},
{"abc-de", 6, "abc-de", true},
{"abc-de", 7, "abc-de", true},
{"abc-de-fg", 6, "abc-de", true},
{"abc-de-fg", 7, "abc-de", true},
{"abc-de-fg", 8, "abc-de", true},
{"abc-de-fg", 9, "abc-de-fg", true},
{"abc-de-fg", 10, "abc-de-fg", true},

{"DOBROSLAWZYBORT", 9, "dobroslaw", true},
{"DOBROSLAWZYBORT", 100, "dobroslawzybort", true},
{" Dobroslaw Zybort ?", 12, "dobroslaw", true},
{"Ala ma 6 kotów.", 10, "ala-ma-6", true},
{"Dobrosław Żybort", 5, "dobro", true},

// No smart truncate
{"Long branch-name", 14, "long-branch-na", false},
{"Long branch-name", 12, "long-branch", false},
}