Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More testing #25

Merged
merged 2 commits into from
Nov 20, 2024
Merged

More testing #25

merged 2 commits into from
Nov 20, 2024

Conversation

rkeur7
Copy link
Contributor

@rkeur7 rkeur7 commented Nov 19, 2024

No description provided.

@rkeur7 rkeur7 requested a review from a team November 19, 2024 21:45
AdrianCollinsShippo
AdrianCollinsShippo approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@AdrianCollinsShippo AdrianCollinsShippo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFIK it looks fine.
Just raising the github warnings in case you missed them.

Dereference of a possibly null reference.

@rkeur7
Copy link
Contributor Author

rkeur7 commented Nov 20, 2024

@AdrianCollinsShippo Thanks for the attention to detail. That error has been there all along, it's part of a smaller issue with our C# SDK generation (non-blocking).

@rkeur7 rkeur7 merged commit 6553398 into main Nov 20, 2024
1 check passed
@rkeur7 rkeur7 deleted the chore-test-validation branch November 20, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianCollinsShippo AdrianCollinsShippo AdrianCollinsShippo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkeur7 @AdrianCollinsShippo