Remove log.Fatal() usage in encoder.go

[h2570su]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Go Version Update
• Dependency Update

Description

Related Tickets & Documents

• Related Issue #
• Closes [GPT-98] Update go version & add verification/testing tools #200

Added/updated tests?

• Yes
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

Run verifications and test

• make verify is passing
• make test is passing

[AlexVulaj]

Hi @h2570su , thanks for contributing! Could you provide a bit more information about why this change is necessary or what problems it solves?

[h2570su]

log.Fatal() exits the program immediately.
In my opinion, that should been used only if the error is unrecoverable and critical enough.
And shouldn't been used in a library because a main program maybe using a different logger implementation, exiting program by std library logger could be hard to trace the location error occurred.

The encoder is returning error, the procedure encoder during reflection fails won't harms whole program.
Returning a error to top-level is enough.

[jaitaiwan]

This looks like a no brainer to me. I won't merge but I think it's pretty critical to merge it.

[jaitaiwan]

Merged, Thanks for the contribution @h2570su!