Skip to content

Commit

Permalink
Don't use subtests for MiddlewareAdd
Browse files Browse the repository at this point in the history
  • Loading branch information
Franklin Harding committed Jun 28, 2019
1 parent f3ac46d commit 0761e9b
Showing 1 changed file with 18 additions and 8 deletions.
26 changes: 18 additions & 8 deletions middleware_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,24 @@ func TestMiddlewareAdd(t *testing.T) {
router := NewRouter()
router.HandleFunc("/", dummyHandler).Methods("GET")

for i := 0; i < 3; i++ {
t.Run(fmt.Sprintf("adds %d middlewares", i+1), func(t *testing.T) {
mw := &testMiddleware{}
router.useInterface(mw)
if len(router.middlewares) != i+1 || router.middlewares[i] != mw {
t.Fatalf("Middleware %d was not added correctly", i+1)
}
})
mw := &testMiddleware{}

router.useInterface(mw)
if len(router.middlewares) != 1 || router.middlewares[0] != mw {
t.Fatal("Middleware interface was not added correctly")
}

router.Use(mw.Middleware)
if len(router.middlewares) != 2 {
t.Fatal("Middleware method was not added correctly")
}

banalMw := func(handler http.Handler) http.Handler {
return handler
}
router.Use(banalMw)
if len(router.middlewares) != 3 {
t.Fatal("Middleware function was not added correctly")
}
}

Expand Down

0 comments on commit 0761e9b

Please sign in to comment.