-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure icon & context menu are up to date on window focus change
Related issue: - uBlockOrigin/uBlock-issues#151 Related feedback: - uBlockOrigin/uBlock-issues#680 (comment)
- Loading branch information
Showing
1 changed file
with
19 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any change in the feedback I posted in uBlockOrigin/uBlock-issues#680 (comment) with this commit, I can still reproduce that.
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The toolbar icon is properly updated whenever I bring forth the tab. It won't update until you bring forth the tab, because I do not want uBO to force-update the icon until the tab is activated, because someone could have hundreds of tabs and I figure that would cause noticeable performance issue.
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks that will work but you will have click on the tab to make it active even if it's active after closing the new window which we opened to remove the rule in Whitelist tab.
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need to click the tab if it's already active when closing the window, I just tried it and the icon was updated.
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the popup panel open when the tab got switched back to the domain on which you whitelisted ?
What you said works only if the popup panel is closed and the popup panel remains open/won't close automatically when you open dashboard(which I know is new behaviour for a bug you fixed) in a new window.
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the popup panel being open --
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The popup panel closes as soon as the new window opens -- normal browser behavior.
aaee898
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click on the extension icon and open the popup panel.
Right click on Dashboard icon and select Open link in a new window.
This is what happens --
As you can see the popup panel remains open.
Addendum: This behaviour is Chromium specific too. Popup panel does get closed automatically on Firefox.