This repository has been archived by the owner on Jan 11, 2019. It is now read-only.
Allow library to be used in parallel #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows concurrent calls to Parse. Further it makes the test be part of the same package. Fixes gorhill#26
|
@gorhill Is there any reason you aren't merging this? |
|
I haven't touched the code here for years, and anything than trivial changes would require me to devote a lot of time to code review since I would need to all get back how the code works to ensure no regression. |
|
Well if it is of any use to you in your decision, HashiCorp Nomad has been shipping with a fork with this change for many months on tens of thousands of machines with no issue. |
Yes, it does make a difference knowing this -- I will go ahead and merge. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows concurrent calls to Parse. Further it makes the test be
part of the same package.
Fixes #26