Add text section correction factor #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some compilers add code at the beginning of the text section. The go runtime and its internal structures are not aware of this because their start of the text section is different from the values in the PE header. This commit adds code that compares the value in the PE header to the value stored in the module data structure. If the values are different a correction factor is calculated. This correction factor is applied to the function addresses when the r2 command for defining function is executed. In most cases, this factor will be 0, resulting in no change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilers add code at the beginning of the text section. The go runtime and its internal structures are not aware of this because their start of the text section is different from the values in the PE header. This commit adds code that compares the value in the PE header to the value stored in the module data structure. If the values are different a correction factor is calculated. This correction factor is applied to the function addresses when the r2 command for defining function is executed.
In most cases, this factor will be 0, resulting in no change.