fix: argon2id configuration override #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master goravel/framework#96 +/- ##
==========================================
+ Coverage 51.52% 51.55% +0.02%
==========================================
Files 103 103
Lines 7028 7032 +4
==========================================
+ Hits 3621 3625 +4
Misses 3126 3126
Partials 281 281
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
hwbrzzl
reviewed
Apr 17, 2023
Add it. |
hwbrzzl
reviewed
Apr 17, 2023
| @@ -59,6 +59,12 @@ func (s *ApplicationTestSuite) TestCheckHash() { | |||
| } | |||
| } | |||
|
|
|||
| func (s *ApplicationTestSuite) TestConfigurationOverride() { | |||
| value := "$argon2id$v=19$m=65536,t=8,p=1$NlVjQm5PQUdWTHVTM1RBUg$Q5T7WfeCI7ucIdk6Na6AdQ" | |||
There was a problem hiding this comment.
我们可以根据你自定义配置的发生问题的过程生成这个加密串么？而不是固定写死，这样测试是不是不太能覆盖到问题？
There was a problem hiding this comment.
我们可以根据你自定义配置的发生问题的过程生成这个加密串么？而不是固定写死，这样测试是不是不太能覆盖到问题？
问题的哈希是从数据库取出来的，因为是其他程序生成的，所以参数不一样。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve goravel/goravel#158