filesystem add file meta methods #92
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
==========================================
- Coverage 51.52% 51.25% -0.27%
==========================================
Files 103 103
Lines 7028 7102 +74
==========================================
+ Hits 3621 3640 +19
- Misses 3126 3178 +52
- Partials 281 284 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
filesystem/local.go
Outdated
| func (r *Local) MakeDirectory(directory string) error { | ||
| return os.MkdirAll(path.Dir(r.fullPath(directory)+"/"), os.ModePerm) | ||
| } | ||
|
|
||
| func (r *Local) MimeType(file string) (string, error) { | ||
| mtype, err := mimetype.DetectFile(r.fullPath(file)) |
There was a problem hiding this comment.
Q: We have a third package to get minetype now: github.com/h2non/filetype, can we use it?
dhanusaputra
force-pushed
the
filesystem-add-filemeta
branch
from
250fee6 to
8a3a68f
Compare
|
seems adding unit test with external method like minio, s3.HeadObject, etc. is not easy |
Oh, yes, let me do it, I'll merge this PR when I start, maybe one week. Thanks for your hard work on this PR! |
|
Hey @dhanusaputra We created a private channel in Discord for contributors. You can click the link and DM me (@bowen) to join it if you are interested. Here you can:
|
close goravel/goravel#94
sizeis already implemented