-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [#531] An extra log will be printed when using a custom log driver #753
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? πͺ§ TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -343,8 +357,6 @@ func registerHook(config config.Config, json foundation.Json, instance *logrus.L | |||
return errors.New("Error logging channel: " + channel) | |||
} | |||
|
|||
instance.SetFormatter(formatter.NewGeneral(config, json)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main error is that this line is added to all channels.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.14.x #753 +/- ##
==========================================
Coverage ? 69.40%
==========================================
Files ? 176
Lines ? 13252
Branches ? 0
==========================================
Hits ? 9197
Misses ? 3480
Partials ? 575 β View full report in Codecov by Sentry. |
π Description
Closes goravel/goravel#531
Tested locally, it's hard to add a test case:
@coderabbitai summary
β Checks