-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rate limiter and throttle middleware #518
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
==========================================
- Coverage 69.97% 69.90% -0.07%
==========================================
Files 179 180 +1
Lines 10952 11000 +48
==========================================
+ Hits 7664 7690 +26
- Misses 2719 2739 +20
- Partials 569 571 +2 β View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, just a few questions.
And please add some integration tests in goravel/example after merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great optimization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great π
π Description
Closes goravel/goravel#448
https://github.com/sethvargo/go-limiter package's
go.mod
configure to go 1.22, so it cannot be merged intov1.14.x
.β Checks