Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#388] [Bug] data error when calling facades.Auth().Parse() multiple times with different guard #458

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

hwbrzzl
Copy link
Contributor

@hwbrzzl hwbrzzl commented Apr 17, 2024

Closes goravel/goravel#388

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@hwbrzzl hwbrzzl changed the base branch from master to v1.13.x April 17, 2024 09:01
@hwbrzzl hwbrzzl requested a review from a team April 17, 2024 09:02
@hwbrzzl hwbrzzl closed this Apr 17, 2024
@hwbrzzl hwbrzzl reopened this Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 44.90%. Comparing base (ad61d31) to head (06578d4).
Report is 95 commits behind head on v1.13.x.

Additional details and impacted files
@@             Coverage Diff              @@
##           v1.13.x     #458       +/-   ##
============================================
- Coverage    62.24%   44.90%   -17.34%     
============================================
  Files          125      231      +106     
  Lines         8078    17121     +9043     
============================================
+ Hits          5028     7689     +2661     
- Misses        2717     8884     +6167     
- Partials       333      548      +215     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Member

@kkumar-gcc kkumar-gcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

Copy link
Member

@devhaozi devhaozi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwbrzzl hwbrzzl merged commit 87a80b3 into v1.13.x Apr 17, 2024
9 of 10 checks passed
@hwbrzzl hwbrzzl deleted the bowen/#388 branch April 17, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

πŸ› [Bug] data error when calling facades.Auth().Parse() multiple times with different guard
3 participants