Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add carbon #177

Merged
merged 21 commits into from
Jun 12, 2023
Merged

feat: add carbon #177

merged 21 commits into from
Jun 12, 2023

Conversation

devhaozi
Copy link
Member

@devhaozi devhaozi commented Jun 10, 2023

Closes goravel/goravel#40

πŸ“‘ Description

Add carbon as time support.

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

none.

@devhaozi devhaozi enabled auto-merge (squash) June 10, 2023 19:40
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Jun 11, 2023

How about creating a top folder /carbon, User can import github.com/goravel/framework/carbon and use carbon.*.

@devhaozi
Copy link
Member Author

ok, let me check it.

@devhaozi
Copy link
Member Author

@hwbrzzl Can you help me see why several tests of Auth fail, it's very strange.

@devhaozi
Copy link
Member Author

@hwbrzzl Can you help me see why several tests of Auth fail, it's very strange.

image
The time has elapsed, but no ErrorTokenExpired thrown.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.29 πŸŽ‰

Comparison is base (6b06c03) 61.22% compared to head (dca85d8) 62.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
+ Coverage   61.22%   62.52%   +1.29%     
==========================================
  Files         124      125       +1     
  Lines        7877     8136     +259     
==========================================
+ Hits         4823     5087     +264     
+ Misses       2725     2722       -3     
+ Partials      329      327       -2     
Impacted Files Coverage Ξ”
auth/auth.go 84.45% <100.00%> (+0.10%) ⬆️
carbon/carbon.go 100.00% <100.00%> (ΓΈ)
carbon/json.go 100.00% <100.00%> (ΓΈ)
database/console/migrate_creator.go 54.54% <100.00%> (ΓΈ)
database/gorm/gorm.go 67.44% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Just a few tips.

auth/auth.go Outdated Show resolved Hide resolved
auth/auth.go Show resolved Hide resolved
database/console/migrate_make_command_test.go Outdated Show resolved Hide resolved
database/console/migrate_make_command_test.go Outdated Show resolved Hide resolved
database/orm/model.go Show resolved Hide resolved
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit 5a39053 into master Jun 12, 2023
@devhaozi devhaozi deleted the haozi/add-carbon branch June 12, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] Time processing
2 participants