Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make command add subdirectories support #176

Merged
merged 14 commits into from
Jun 11, 2023
Merged

Conversation

devhaozi
Copy link
Member

Closes goravel/goravel#72

πŸ“‘ Description

make command add subdirectories support

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

none.

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage: 96.22% and project coverage change: +0.57 πŸŽ‰

Comparison is base (8b450ae) 60.57% compared to head (037b17a) 61.15%.

❗ Current head 037b17a differs from pull request most recent head 8699a98. Consider uploading reports for the commit 8699a98 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   60.57%   61.15%   +0.57%     
==========================================
  Files         120      124       +4     
  Lines        7531     7877     +346     
==========================================
+ Hits         4562     4817     +255     
- Misses       2643     2730      +87     
- Partials      326      330       +4     
Impacted Files Coverage Ξ”
support/str/str.go 69.49% <75.00%> (-2.93%) ⬇️
event/console/event_make_command.go 68.75% <80.95%> (+6.68%) ⬆️
event/console/listener_make_command.go 70.00% <82.60%> (+6.66%) ⬆️
auth/console/policy_make_command.go 74.50% <100.00%> (+16.44%) ⬆️
auth/console/policy_stubs.go 100.00% <100.00%> (ΓΈ)
console/console/make_command.go 71.73% <100.00%> (ΓΈ)
console/console/stubs.go 100.00% <100.00%> (ΓΈ)
database/console/model_make_command.go 75.47% <100.00%> (+14.86%) ⬆️
database/console/observer_make_command.go 75.47% <100.00%> (+14.86%) ⬆️
database/console/stubs.go 100.00% <100.00%> (ΓΈ)
... and 10 more

... and 2 files with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@devhaozi devhaozi enabled auto-merge (squash) June 10, 2023 12:49
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

auth/console/policy_make_command.go Outdated Show resolved Hide resolved
auth/console/policy_make_command.go Outdated Show resolved Hide resolved
auth/console/policy_make_command_test.go Show resolved Hide resolved
console/console/make_command.go Outdated Show resolved Hide resolved
console/console/make_command_test.go Show resolved Hide resolved
@devhaozi devhaozi requested a review from hwbrzzl June 11, 2023 05:02
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found another two tips ~

event/console/event_make_command.go Outdated Show resolved Hide resolved
event/console/listener_make_command.go Outdated Show resolved Hide resolved
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM

@devhaozi devhaozi merged commit 6b06c03 into master Jun 11, 2023
@devhaozi devhaozi deleted the haozi/refactor-make branch June 11, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature] make command supports subdirectory
2 participants