Feat: [#133] Add All and Queries methods to Request #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwbrzzl
commented
May 22, 2023
There was a problem hiding this comment.
Only add All and Queries methods, other methods just change order.
hwbrzzl
commented
May 22, 2023
Comment on lines
+37
to
40
| // DEPRECATED: Use input instead. Retrieve a form string item from the post: /users POST:id=1, | ||
| Form(key string, defaultValue ...string) string | ||
| // Json Retrieve data from the post: /users JSON:{"id": 1} | ||
| // DEPRECATED: Use input instead. Retrieve data from the post: /users JSON:{"id": 1} | ||
| Json(key string, defaultValue ...string) string |
There was a problem hiding this comment.
Deprecate these methods.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 53.36% 52.95% -0.41%
==========================================
Files 105 105
Lines 7500 7558 +58
==========================================
Hits 4002 4002
- Misses 3219 3277 +58
Partials 279 279
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: goravel/goravel#133