Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filesystem windows support #109

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Conversation

devhaozi
Copy link
Member

No description provided.

@devhaozi devhaozi self-assigned this Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (80ac31b) 54.05% compared to head (75630a5) 54.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   54.05%   54.08%   +0.02%     
==========================================
  Files         105      105              
  Lines        7379     7375       -4     
==========================================
  Hits         3989     3989              
+ Misses       3112     3108       -4     
  Partials      278      278              
Impacted Files Coverage Δ
filesystem/local.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

hwbrzzl
hwbrzzl previously approved these changes Apr 26, 2023
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Close goravel/goravel#105

@devhaozi devhaozi enabled auto-merge (squash) April 26, 2023 10:36
@devhaozi devhaozi requested a review from hwbrzzl April 26, 2023 10:36
@hwbrzzl
Copy link
Contributor

hwbrzzl commented Apr 26, 2023

Hi, @devhaozi I added a new label: Ready For Review, you can add it when this PR can be reviewed.

@devhaozi
Copy link
Member Author

Hi, @devhaozi I added a new label: Ready For Review, you can add it when this PR can be reviewed.

OK

@devhaozi devhaozi changed the title fix: windows support fix: filesystem windows support Apr 26, 2023
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit 64e0e09 into master Apr 26, 2023
@devhaozi devhaozi deleted the filesystem-windows-support branch April 26, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] facades.Storage.Path return error path in Windows
2 participants