Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crypt print in artisan command #104

Merged
merged 3 commits into from
Apr 26, 2023
Merged

fix: Crypt print in artisan command #104

merged 3 commits into from
Apr 26, 2023

Conversation

devhaozi
Copy link
Member

No description provided.

@devhaozi devhaozi enabled auto-merge (squash) April 25, 2023 17:52
@devhaozi devhaozi requested a review from hwbrzzl April 25, 2023 17:52
@devhaozi devhaozi self-assigned this Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (305b758) 54.06% compared to head (f8f8d86) 54.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   54.06%   54.05%   -0.01%     
==========================================
  Files         105      105              
  Lines        7374     7379       +5     
==========================================
+ Hits         3987     3989       +2     
- Misses       3110     3112       +2     
- Partials      277      278       +1     
Impacted Files Coverage Δ
crypt/aes.go 53.42% <50.00%> (-0.99%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devhaozi devhaozi merged commit 96c5090 into master Apr 26, 2023
@devhaozi devhaozi deleted the fix-crypt-print branch April 26, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] When first generate key, facades.Crypt print a red message
2 participants