Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alps 904 - Video quality change #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Alps 904 - Video quality change #73

wants to merge 2 commits into from

Commits on May 29, 2017

  1. When requesting quickly a change in the quality of a video, the 

    HTMLVideoElement wasn't always ready and thus null. We tried to remove
some EventListener of something null, so it crashed. It is not the case
anymore, as a check on the HTMLVideoElement (either null or undefined)
is done.
    @aberthet-gpsw
    aberthet-gpsw committed May 29, 2017
    Configuration menu
    Copy the full SHA
    be6939f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2017

  1. Fix two bugs when the video was seeking: 

    - first one was when you made a quick request in the quality change of
the video, the video would crash
- second one was when you made a quick request in the quality change of
the video, when reaching the end the video would crash, even if resuming
was set to true
    @aberthet-gpsw
    aberthet-gpsw committed May 30, 2017
    Configuration menu
    Copy the full SHA
    fa9753e View commit details
    Browse the repository at this point in the history